launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #13213
[Merge] lp:~stevenk/launchpad/urifield-with-leading-space into lp:launchpad
The proposal to merge lp:~stevenk/launchpad/urifield-with-leading-space into lp:launchpad has been updated.
Description changed to:
URIWidget is now a subclass of StrippedTextWidget, which means it will strip leading and trailing whitespace. This fixes the root cause for the OOPS, since the database validation function valid_absolute_url() insists unstripped text is invalid, but URIField's validation method strips URIs before validation.
I've cleaned up some whitespace and pylint garbage to force this branch to net-negative, and have cleaned up a very weird copyright header that was completely lowercased.
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/urifield-with-leading-space/+merge/128855
--
https://code.launchpad.net/~stevenk/launchpad/urifield-with-leading-space/+merge/128855
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/urifield-with-leading-space into lp:launchpad.
References