launchpad-reviewers team mailing list archive

[John A Meinel <john@xxxxxxxxxxxxxxxxx>]

John A Meinel has proposed merging lp:~jameinel/maas/simplejson-speed into lp:maas.

Commit message:
Use simplejson instead of python's native json for json.loads().

It turns out that simplejson is about 2x faster than json at loading the big strings of XML content we are sending. This shaves off another 10% of the time spent processing a new tag. (27s down from 30s on 10,000 nodes with other patches applied.)

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jameinel/maas/simplejson-speed/+merge/128927
-- 
https://code.launchpad.net/~jameinel/maas/simplejson-speed/+merge/128927
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jameinel/maas/simplejson-speed into lp:maas.

=== modified file 'src/provisioningserver/tags.py'
--- src/provisioningserver/tags.py	2012-10-08 15:03:15 +0000
+++ src/provisioningserver/tags.py	2012-10-10 13:09:30 +0000
@@ -6,7 +6,7 @@
 """
 
 import httplib
-import json
+import simplejson as json
 from lxml import etree
 
 from apiclient.maas_client import (