launchpad-reviewers team mailing list archive

Thread
Date

Re: lp:~adeuring/launchpad/authentication-for-private-products into lp:launchpad

To: Abel Deuring <abel.deuring@xxxxxxxxxxxxx>
From: Abel Deuring <abel.deuring@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2012 19:44:20 -0000
In-reply-to: <20121010182620.7424.82262.launchpad@ackee.canonical.com>
Reply-to: mp+129014@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I think we should not return True for inactive products. In that case, oridnary users will be able to see these inactive products. Or we separate the checkers for IPillar and IProductView. But as we discussed in a hangout, I had a hard time to implement this when the permission lp.View is used both for IPillar and IProductView.
-- 
https://code.launchpad.net/~adeuring/launchpad/authentication-for-private-products/+merge/129014
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~adeuring/launchpad/authentication-for-private-products into lp:launchpad
From: Abel Deuring, 2012-10-10