launchpad-reviewers team mailing list archive

[Andres Rodriguez <andreserl@xxxxxxxxxxxxx>]

Review: Needs Fixing

Hi Julian,

So doing this will result in having both maas-region-controller and maas-cluster-controller shipping 'maas' in /usr/share/maas. This will cause a conflict on installation.

Since this is now required for both, the region and cluster, this should no longer be installer with maas-region-controller (as it currently is) and should be installed in a common package. I'm guessing that the best place to so so is in maas-common.

Futhermore, once this is installed on maas-common, and no longer installed in maas-region-controller, maas-common will require Replaces/Conflicts for maas-region controller (<= 0.1+bzr1243+dfsg-0ubuntu3 ).

Hope this helps.

Cheers.
-- 
https://code.launchpad.net/~julian-edwards/maas/missing-import-bug-1065055/+merge/129080
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/maas/missing-import-bug-1065055 into lp:~maas-maintainers/maas/packaging.