← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~jelmer/maas/retry-tag-updates into lp:maas

 

Jelmer Vernooij has proposed merging lp:~jelmer/maas/retry-tag-updates into lp:maas.

Commit message:
Fix the process_node_tags task to use the right max_retries constant.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jelmer/maas/retry-tag-updates/+merge/129175

Fix the process_node_tags task to use the right max_retries constant.

(Followup branch to https://code.launchpad.net/~jelmer/maas/retry-update-node-tags/+merge/128885)
-- 
https://code.launchpad.net/~jelmer/maas/retry-tag-updates/+merge/129175
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/maas/retry-tag-updates into lp:maas.
=== modified file 'src/provisioningserver/tasks.py'
=== modified file 'src/provisioningserver/tests/test_tags.py'
--- src/provisioningserver/tests/test_tags.py	2012-10-10 08:58:45 +0000
+++ src/provisioningserver/tests/test_tags.py	2012-10-11 12:45:30 +0000
@@ -132,10 +132,8 @@
         self.patch(MAASClient, 'get')
         self.patch(MAASClient, 'post')
         tag_name = factory.make_name('tag')
-        try:
-            tags.process_node_tags(tag_name, '//node')
-        except tags.MissingCredentials:
-            pass
+        self.assertRaises(tags.MissingCredentials,
+            tags.process_node_tags, tag_name, '//node')
         self.assertFalse(MAASClient.get.called)
         self.assertFalse(MAASClient.post.called)