← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~rharding/launchpad/bp_validate_type_1062198 into lp:launchpad

 

Review: Approve code

Thank you.

I think this is good to land, but I wonder the validate method be calling something in the model? I know that I cannot create a Specification from the API, but we had to move a lot of rules into the model when we realised that API and model code also need to know about valid states.
-- 
https://code.launchpad.net/~rharding/launchpad/bp_validate_type_1062198/+merge/129270
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References