launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~nigelbabu/launchpad/logo-links-713873 into lp:launchpad

To: Nigel Babu <nigelbabu@xxxxxxxxx>
From: Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>
Date: Fri, 12 Oct 2012 21:16:20 -0000
In-reply-to: <20120116012923.25338.86483.launchpad@ackee.canonical.com>
Reply-to: mp+88631@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

I am rejecting this branch because a lot more work is needed to address this bug. As can be seeing lib/lp/app/browser/tales.py, getting the URL for a logo or mugshot is not simple. The proposed interface changes are fine. The implementation would need to move the URL logic from tales.py into the model. And any changes will need to be tested.
-- 
https://code.launchpad.net/~nigelbabu/launchpad/logo-links-713873/+merge/88631
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~nigelbabu/launchpad/logo-links-713873 into lp:launchpad
From: Nigel Babu, 2012-01-16