launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

I'd still like to see an emergency feature flag in userCanView, in case we end up with the initial private projects on production breaking something unexpected. But otherwise this looks pretty good, particularly the improvements around handling deactivated products.

969	+ if (user.in_commercial_admin or user.in_admin or
970	+ user.in_registry_experts):

There are registry admins from outside Canonical, so ~registry must not be able to see all private projects.

Also, you can also easily fix bug #1061933 while you're here.
-- 
https://code.launchpad.net/~adeuring/launchpad/authentication-for-private-products-2/+merge/129459
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.