launchpad-reviewers team mailing list archive

[Zygmunt Krynicki <zygmunt.krynicki@xxxxxxxxxxxxx>]

Zygmunt Krynicki has proposed merging lp:~zkrynicki/maas/fix-1066935 into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1066935 in MAAS: "named.conf.rndc.maas is insecure by default"
  https://bugs.launchpad.net/maas/+bug/1066935

For more details, see:
https://code.launchpad.net/~zkrynicki/maas/fix-1066935/+merge/129708

This branch attempts to fix https://bugs.launchpad.net/maas/+bug/1066935

Since this is my first maas contribution unit tests are not present yet.
I'll be working with the maas core development team to add them.
-- 
https://code.launchpad.net/~zkrynicki/maas/fix-1066935/+merge/129708
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~zkrynicki/maas/fix-1066935 into lp:maas.

=== modified file 'src/provisioningserver/dns/config.py'
--- src/provisioningserver/dns/config.py	2012-10-05 08:21:10 +0000
+++ src/provisioningserver/dns/config.py	2012-10-15 16:11:33 +0000
@@ -106,6 +106,7 @@
 
     target_file = get_named_rndc_conf_path()
     with open(target_file, "wb") as f:
+        os.fchmod(f.fileno(), 0600)
         f.write(named_content)