launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

The proposal to merge lp:~rharding/launchpad/info_portlet_1052551 into lp:launchpad has been updated.

Description changed to:

= Summary =

See the bug for details on how users are unable to change the InformationType
on the bluesprints from the portlet.

== Implementation Notes ==

This fixes a couple of manual styles added to the choice widget setup as well
as a missed rename for the javascript method setup_information_type_choice to
setup_choice.

#24 Removes manual display:none set on the Edit action icon.

#47 Removes the manual setting of the icon to display:inline

The rest is mainly some matching of the layout of the HTML to the same thing
in the bug portlet so that I could compare the html and css classes required
to get things to work correctly.

There's also the drive by update of adding the JS module dep lp.app.choice to the addspec.js. It's indirectly gotten from requiring information_type.js, but it does use lp.app.choice directly and should be required as well.

== Q/A ==

When viewing a blueprint you should see the privacy portlet on the right side
and the edit icon should be available to change the information type.

For more details, see:
https://code.launchpad.net/~rharding/launchpad/info_portlet_1052551/+merge/129706
-- 
https://code.launchpad.net/~rharding/launchpad/info_portlet_1052551/+merge/129706
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/info_portlet_1052551 into lp:launchpad.