launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve

Thanks Abel, looks good with some typo nitpicks and one question for you.

#155 Should the check here be against distributions directed instead of indirectly using product?

#260 Typo in assertAccessAuthorzized (Authorized) [ok, find and repeat throughout here]

#264 Typo implenet (implement)

#285 "may not"

#302 "have access to public"

#328 I would have expected the user to have access to the information on a public milestone? Is this an incorrect assumption? I guess not since they'd not have access to launchpad.View permissions.

-- 
https://code.launchpad.net/~adeuring/launchpad/milestone-sec-adapter/+merge/129917
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.