launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #13472
Re: [Merge] lp:~sinzui/launchpad/nominations-investigation-4 into lp:launchpad
I ran all the bug tests and there were no failures.
Total: 2817 tests, 0 failures, 0 errors in 70 minutes 1.767 seconds.
The two tests I did fix, as I mentioned in the cover text, were caught in my search for tests exercises the method I changed. Only one test in test_bugchanges.py, which dealt with milestones. Instead of just fixing the one broken test, I changed the helper method because the helper was trying to represent a second request. The doctest fix is keeping a mediocre test alive.
--
https://code.launchpad.net/~sinzui/launchpad/nominations-investigation-4/+merge/129990
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/nominations-investigation-4 into lp:launchpad.
References