← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jcsackett/launchpad/unreliable-session-service into lp:launchpad

 

Review: Approve code

I think the test would be a little safer if the close() method was restored.

from lp.testing import monkey_patch
...
    with monkey_patch(session._connection, close=new_closed):
        session.disconnect()
        self.assertFalse(session.is_connected)
-- 
https://code.launchpad.net/~jcsackett/launchpad/unreliable-session-service/+merge/129981
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References