← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~wallyworld/launchpad/vouchers-timeout-1014641 into lp:launchpad

 

> Remove the submit-twice-error you added to
> lib/lp/registry/doc/commercialsubscription.txt because you wrote a unit test
> for it.
> 

The tests are subtly different. The doc test is a unit test for the model object and the raising of the VoucherAlreadyRedeemed exception. The unit test is for the view layer and checks that the model exception is handled correctly.


-- 
https://code.launchpad.net/~wallyworld/launchpad/vouchers-timeout-1014641/+merge/129862
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References