launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Review: Needs Fixing code

The docstring for IPerson.findVisibleAssignedInProgressSpecs() makes no mention that it will only return five specs. I'd prefer the model function also includes the usual "See `Interface'." docstring.

This also means this code will now rely on get_specification_privacy_filter rather than OOPSing. Due to the query that is run by that function, I suspect we are now trading OOPSes for timeouts. I'd *really* prefer the access mechanisms for Specifications are de-normalized like they are for bugs and branches. I'd like to see some investigation of the query that get_specification_privacy_filter runs before I approve this branch.
-- 
https://code.launchpad.net/~abentley/launchpad/person-assigned-specs-in-progress/+merge/130888
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.