launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/maas/sort-icons into lp:maas.

Commit message:
Changed sort icon colour, renamed icons, improved positioning, fixed/cleaned up css

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~huwshimi/maas/sort-icons/+merge/131350

In this branch:
- changed sort icon colour
- renamed icon filenames
- improved positioning
- fixed/cleaned up css
-- 
https://code.launchpad.net/~huwshimi/maas/sort-icons/+merge/131350
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/maas/sort-icons into lp:maas.

=== modified file 'src/maasserver/static/css/components/table_list.css'
--- src/maasserver/static/css/components/table_list.css	2012-10-24 12:51:10 +0000
+++ src/maasserver/static/css/components/table_list.css	2012-10-25 09:36:23 +0000
@@ -30,16 +30,18 @@
     border-color: #dd4814;
     cursor: pointer;
     }
-.sort-none, .sort-asc, .sort-desc {
+.sort-none,
+.sort-asc,
+.sort-desc {
     background-repeat: no-repeat;
-    background-position: right 0.4em;
-    padding-right: 1.2em;
+    background-position: right center;
+    padding-right: 16px;
     }
 .sort-asc {
-    background-image: url('/static/img/up_arrow_dark.png');
+    background-image: url('../?img/sort_down.png');
     }
 .sort-desc {
-    background-image: url('/static/img/down_arrow_dark.png');
+    background-image: url('../?img/sort_up.png');
     }
 /* ul list */
 ul.list {

=== renamed file 'src/maasserver/static/img/down_arrow_dark.png' => 'src/maasserver/static/img/sort_ascending.png'
Binary files src/maasserver/static/img/down_arrow_dark.png	2012-10-24 12:51:10 +0000 and src/maasserver/static/img/sort_ascending.png	2012-10-25 09:36:23 +0000 differ
=== renamed file 'src/maasserver/static/img/up_arrow_dark.png' => 'src/maasserver/static/img/sort_descending.png'
Binary files src/maasserver/static/img/up_arrow_dark.png	2012-10-24 12:51:10 +0000 and src/maasserver/static/img/sort_descending.png	2012-10-25 09:36:23 +0000 differ