launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/maas/icon-underlines into lp:maas.

Commit message:
Add icon classes to fix link hovers.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1067925 in MAAS: "trailing underline when you mouse over the edit icon"
  https://bugs.launchpad.net/maas/+bug/1067925

For more details, see:
https://code.launchpad.net/~huwshimi/maas/icon-underlines/+merge/131404

Added the "icon" class to edit links so that the hover underline doesn't appear.
-- 
https://code.launchpad.net/~huwshimi/maas/icon-underlines/+merge/131404
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/maas/icon-underlines into lp:maas.

=== modified file 'src/maasserver/templates/maasserver/nodegroup_edit.html'
--- src/maasserver/templates/maasserver/nodegroup_edit.html	2012-10-15 09:32:06 +0000
+++ src/maasserver/templates/maasserver/nodegroup_edit.html	2012-10-25 13:22:21 +0000
@@ -39,6 +39,7 @@
           <td>{{ interface.display_management }}</td>
           <td>
             <a href="{% url 'cluster-interface-edit' uuid=cluster.uuid interface=interface.interface %}"
+               class="icon"
                title="Edit interface {{ interface.interface }}">
               <img src="{{ STATIC_URL }}img/edit.png"
                    alt="edit"

=== modified file 'src/maasserver/templates/maasserver/settings_cluster_listing_row.html'
--- src/maasserver/templates/maasserver/settings_cluster_listing_row.html	2012-10-04 07:43:24 +0000
+++ src/maasserver/templates/maasserver/settings_cluster_listing_row.html	2012-10-25 13:22:21 +0000
@@ -3,6 +3,7 @@
   <td>{{ cluster.cluster_name }}</td>
   <td>
     <a href="{% url 'cluster-edit' cluster.uuid %}"
+       class="icon"
        title="Edit cluster {{ cluster.cluster_name }}">
       <img src="{{ STATIC_URL }}img/edit.png"
            alt="edit"