launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

Review: Approve

Looks good, except for one thing:

#318 I would add the new argument to the end of the arg list. While *probably* all of the args are being invoked as keyword args, they *can* be invoked as positional, and your change throws off the ordering in that case. I won't block approval on that, but please fix it before landing.
-- 
https://code.launchpad.net/~wallyworld/launchpad/bug-distrotask-timeout-1012309/+merge/131308
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.