launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~abentley/launchpad/person-assigned-specs-in-progress into lp:launchpad

To: Aaron Bentley <aaron@xxxxxxxxxxxxx>
From: Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>
Date: Fri, 26 Oct 2012 07:09:29 -0000
In-reply-to: <20121022200118.8563.71471.launchpad@ackee.canonical.com>
Reply-to: mp+130888@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Steve, we really need to get this landed, so I'm going to mark this approved for Aaron, since I read your comments to say you don't have any other objections.  I'm basing my reading of this on the fact that you wouldn't block on the queries, and the NULL thing was just our mistake in data substitution.

If there are other concerns, please reach out the either me or Aaron and we can sort them out in another branch.
-- 
https://code.launchpad.net/~abentley/launchpad/person-assigned-specs-in-progress/+merge/130888
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~abentley/launchpad/person-assigned-specs-in-progress into lp:launchpad
From: Aaron Bentley, 2012-10-22