launchpad-reviewers team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

Julian Edwards has proposed merging lp:~julian-edwards/maas/1.1-stop-power-params-leak-bug-1034318 into lp:maas/12.04-nocobbler.

Commit message:
Prevent power parameters being leaked on the API

Requested reviews:
  Julian Edwards (julian-edwards)
Related bugs:
  Bug #1034318 in MAAS: "API calls that return a node leak private data"
  https://bugs.launchpad.net/maas/+bug/1034318

For more details, see:
https://code.launchpad.net/~julian-edwards/maas/1.1-stop-power-params-leak-bug-1034318/+merge/131549
-- 
https://code.launchpad.net/~julian-edwards/maas/1.1-stop-power-params-leak-bug-1034318/+merge/131549
Your team MAAS Maintainers is subscribed to branch lp:maas/12.04-nocobbler.

=== modified file 'src/maasserver/api.py'
--- src/maasserver/api.py	2012-09-14 17:07:54 +0000
+++ src/maasserver/api.py	2012-10-26 08:22:21 +0000
@@ -417,7 +417,6 @@
     'status',
     'netboot',
     'power_type',
-    'power_parameters',
     )
 
 

=== modified file 'src/maasserver/tests/test_api.py'
--- src/maasserver/tests/test_api.py	2012-09-14 17:07:54 +0000
+++ src/maasserver/tests/test_api.py	2012-10-26 08:22:21 +0000
@@ -487,7 +487,6 @@
                 'status',
                 'netboot',
                 'power_type',
-                'power_parameters',
             ],
             list(parsed_result))
 
@@ -547,7 +546,6 @@
                 'status',
                 'netboot',
                 'power_type',
-                'power_parameters',
                 'resource_uri',
             ],
             list(parsed_result))
@@ -687,7 +685,6 @@
                 'status',
                 'netboot',
                 'power_type',
-                'power_parameters',
                 'resource_uri',
             ],
             list(parsed_result))