launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #13818
Re: lp:~adeuring/launchpad/filter-private-product-RosettaApplication into lp:launchpad
Review: Approve
Looks good, generally. As mentioned here in person, we need an XXX to note that we don't want this check for NULL once Product.information_type cannot be NULL. Once the XXX is in place, landing this sounds fine. Also, please add a card to the Kanban board reminding us to revisit this code.
--
https://code.launchpad.net/~adeuring/launchpad/filter-private-product-RosettaApplication/+merge/131613
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References