← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~stevenk/launchpad/sensible-superseded-by into lp:launchpad

To: Steve Kowalik <stevenk@xxxxxxxxxx>
From: Ian Booth <ian.booth@xxxxxxxxxxxxx>
Date: Tue, 30 Oct 2012 05:07:22 -0000
In-reply-to: <20121030043320.4141.48394.launchpad@ackee.canonical.com>
Reply-to: mp+132009@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good, with the tweaks suggested on irc - lookup blueprint once in validation method, and result set .one()
-- 
https://code.launchpad.net/~stevenk/launchpad/sensible-superseded-by/+merge/132009
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~stevenk/launchpad/sensible-superseded-by into lp:launchpad
From: Steve Kowalik, 2012-10-30