launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

I'd like not to have to do that here - the idea was simply to tweak the 
existing implementation. There's already been a previous attempt to 
re-implement the override stuff as an adaptor but that stuff is not 
used everywhere yet. That level of refactoring is best done in a 
separate branch. I just wanted to fix the critical here. The 
refactoring is not really critical. I think William agrees with the 
approach.

On Wed 31 Oct 2012 16:22:20 EST, Steve Kowalik wrote:
> Review: Needs Fixing code
>
> I think I'd rather see this an Override Policy, like SetToExistingOverridePolicy or so. Instantiate it with the uploaded_file, and allow the policy to work everything out.

-- 
https://code.launchpad.net/~wallyworld/launchpad/package-defaults-192076/+merge/131509
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.