launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

Aaron Bentley has proposed merging lp:~abentley/launchpad/releasefinder-perms into lp:launchpad.

Commit message:
Update permissions for productreleasefinder

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1072729 in Launchpad itself: "private projects break product-release-finder"
  https://bugs.launchpad.net/launchpad/+bug/1072729

For more details, see:
https://code.launchpad.net/~abentley/launchpad/releasefinder-perms/+merge/132587

= Summary =
Fix bug #1072729: private projects break product-release-finder

== Proposed fix ==
Add necessary permissions to productreleasefinder user.

== Pre-implementation notes ==
None

== LOC Rationale ==
Part of Private Projects.

== Implementation details ==
None

== Tests ==
bin/test -t test_findReleases_permissions

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/tests/test_prf_finder.py
  lib/lp/registry/scripts/productreleasefinder/finder.py
  database/schema/security.cfg
-- 
https://code.launchpad.net/~abentley/launchpad/releasefinder-perms/+merge/132587
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/releasefinder-perms into lp:launchpad.

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2012-10-22 02:30:44 +0000
+++ database/schema/security.cfg	2012-11-01 16:18:22 +0000
@@ -442,6 +442,7 @@
 public.accessartifact                   = SELECT, INSERT, DELETE
 public.accesspolicy                     = SELECT
 public.accesspolicyartifact             = SELECT, INSERT, DELETE
+public.accesspolicygrantflat            = SELECT
 public.accessartifactgrant              = SELECT
 public.accesspolicygrant                = SELECT
 public.bug                              = SELECT
@@ -456,6 +457,7 @@
 public.productreleasefile               = SELECT, INSERT, UPDATE
 public.productseries                    = SELECT
 public.sourcepackagename                = SELECT
+public.teamparticipation                = SELECT
 type=user
 
 [pofilestats]

=== modified file 'lib/lp/registry/scripts/productreleasefinder/finder.py'
--- lib/lp/registry/scripts/productreleasefinder/finder.py	2012-10-16 14:31:19 +0000
+++ lib/lp/registry/scripts/productreleasefinder/finder.py	2012-11-01 16:18:22 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2012 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 __metaclass__ = type

=== modified file 'lib/lp/registry/tests/test_prf_finder.py'
--- lib/lp/registry/tests/test_prf_finder.py	2012-09-04 20:50:35 +0000
+++ lib/lp/registry/tests/test_prf_finder.py	2012-11-01 16:18:22 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2012 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 import logging
@@ -59,6 +59,17 @@
                          ('product2', ['filter3', 'filter4']))
 
 
+class FindReleasesDBTestCase(TestCaseWithFactory):
+
+    layer = LaunchpadZopelessLayer
+
+    def test_findReleases_permissions(self):
+        switch_dbuser(config.productreleasefinder.dbuser)
+        prf = ProductReleaseFinder(self.layer.txn, logging.getLogger())
+        # Test that this raises no exceptions.
+        prf.findReleases()
+
+
 class GetFiltersTestCase(TestCaseWithFactory):
 
     layer = LaunchpadZopelessLayer