launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/undisable-tests-redux into lp:launchpad.

Commit message:
Undisable test_sigint_clearly_breaks to see if buildbot loves it.

Requested reviews:
  Steve Kowalik (stevenk): code
Related bugs:
  Bug #912287 in Launchpad itself: "test_sigint_exits_cleanly breaks"
  https://bugs.launchpad.net/launchpad/+bug/912287

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/undisable-tests-redux/+merge/132993

Undisable test_sigint_clearly_breaks to see if it still fails on buildbot.
-- 
https://code.launchpad.net/~stevenk/launchpad/undisable-tests-redux/+merge/132993
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'bzrplugins/lpserve/test_lpserve.py'
--- bzrplugins/lpserve/test_lpserve.py	2012-06-29 08:40:05 +0000
+++ bzrplugins/lpserve/test_lpserve.py	2012-11-06 00:04:23 +0000
@@ -611,8 +611,7 @@
     def test_sigterm_exits_nicely(self):
         self._check_exits_nicely(signal.SIGTERM)
 
-    def disable_test_sigint_exits_nicely(self):
-        # XXX: frankban 2012-03-29 bug=828584: This test fails intermittently.
+    def test_sigint_exits_nicely(self):
         self._check_exits_nicely(signal.SIGINT)
 
     def test_child_exits_eventually(self):