launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~dimitern/maas/1.2-node-view-shows-kernel-params into lp:maas/1.2

To: mp+133215@xxxxxxxxxxxxxxxxxx
From: Dimiter Naydenov <dimiter.naydenov@xxxxxxxxxxxxx>
Date: Wed, 07 Nov 2012 17:38:32 -0000
In-reply-to: <20121107110130.29010.81914.launchpad@ackee.canonical.com>
Reply-to: mp+133215@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I'm ready with the changes and tests - everything works with one exception - test_view_node_shows_tag_kernel_params still fails, because it assumes Node.get_effective_kernel_options() returns (Tag, kernel_opts) tuple when a tag has kernel_opts and is applied to a node. So, once https://code.launchpad.net/~jameinel/maas/1.2-kernel-option-tags lands, the failing test should pass.
-- 
https://code.launchpad.net/~dimitern/maas/1.2-node-view-shows-kernel-params/+merge/133215
Your team MAAS Maintainers is requested to review the proposed merge of lp:~dimitern/maas/1.2-node-view-shows-kernel-params into lp:maas/1.2.

References

[Merge] lp:~dimitern/maas/1.2-node-view-shows-kernel-params into lp:maas/1.2
From: Dimiter Naydenov, 2012-11-07