launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

The proposal to merge lp:~wallyworld/launchpad/branchscan-deleted-branch2-602323 into lp:launchpad has been updated.

Description changed to:

== Implementation ==

Ensure branch scan job does not oops if a scanned branch is deleted. Simply catch the lost object exception and log a warning.

Changes in this new version:

- for the celery job infrastructure to see the BranchScanJob created for the test, the test code needs to ensure the current transaction is committed before celery is invoked.
- use standard job metadata to store the branch name instead of a custom attribute

== Tests ==

Write a new TestBranchScanJob test.

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/model/branchjob.py
  lib/lp/code/model/tests/test_branchjob.py

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/branchscan-deleted-branch2-602323/+merge/133392
-- 
https://code.launchpad.net/~wallyworld/launchpad/branchscan-deleted-branch2-602323/+merge/133392
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.