launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #14103
Re: [Merge] lp:~adeuring/launchpad/product-lp-limitedview-2 into lp:launchpad
Review: Approve
Abel--
This looks ok, just one nitpick you can address before landing.
#16: It seems odd to have a test with no assertions--I believe this may throw
off some test machinery. At a minimum, probably worth testing that the bug
does show in contents:
contents = view.render()
self.assertTrue(bug.title in contents)
--
https://code.launchpad.net/~adeuring/launchpad/product-lp-limitedview-2/+merge/133481
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References