← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~rharding/launchpad/add_new_banner into lp:launchpad

To: mp+133736@xxxxxxxxxxxxxxxxxx
From: "j.c.sackett" <jcsackett@xxxxxxxxxxxxx>
Date: Fri, 09 Nov 2012 19:59:22 -0000
In-reply-to: <20121109191025.31054.47611.launchpad@ackee.canonical.com>
Reply-to: mp+133736@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

This code looks good. As we discussed in IRC though, the wiring up will need to be careful to leave a banner present on no-js browsers, which still need to be supported for some time.
-- 
https://code.launchpad.net/~rharding/launchpad/add_new_banner/+merge/133736
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~rharding/launchpad/add_new_banner into lp:launchpad
From: Richard Harding, 2012-11-09