launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/maas/packaging.remove-squashfs into lp:~maas-maintainers/maas/packaging.

Commit message:
Remove all install-via-squashfs support.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1074167 in MAAS: "maas-import-pxe-files fails to download squashfs ephemeral images."
  https://bugs.launchpad.net/maas/+bug/1074167
  Bug #1076409 in MAAS: "maas-import-pxe-files fails when run from trunk"
  https://bugs.launchpad.net/maas/+bug/1076409
  Bug #1077180 in MAAS 1.2: "Not importing Quantal boot images"
  https://bugs.launchpad.net/maas/1.2/+bug/1077180

For more details, see:
https://code.launchpad.net/~allenap/maas/packaging.remove-squashfs/+merge/134086

Counterpart to lp:~allenap/maas/remove-squashfs.
-- 
https://code.launchpad.net/~allenap/maas/packaging.remove-squashfs/+merge/134086
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/packaging.remove-squashfs into lp:~maas-maintainers/maas/packaging.

=== modified file 'debian/changelog'
--- debian/changelog	2012-11-06 17:36:39 +0000
+++ debian/changelog	2012-11-13 12:13:28 +0000
@@ -23,6 +23,11 @@
   * debian/maas-region-controller.postinst: Remove tgt config.
   * debian/maas-region-controller.postrm: Remove tgt config cleanup.
 
+  [ Gavin Panella ]
+  * debian/extras/99-maas: squashfs image download is no longer needed.
+  * debian/maas-cluster-controller.install: maas-import-squashfs and its
+    configuration file are no longer part of upstream.
+
  -- Julian Edwards <julian.edwards@xxxxxxxxxxxxx>  Fri, 26 Oct 2012 12:50:20 +0200
 
 maas (0.1+bzr1269+dfsg-0ubuntu1) quantal-proposed; urgency=low

=== modified file 'debian/extras/99-maas'
--- debian/extras/99-maas	2012-10-04 18:52:27 +0000
+++ debian/extras/99-maas	2012-11-13 12:13:28 +0000
@@ -1,7 +1,4 @@
 # /etc/squid-deb-proxy/mirror-dstdomain.acl.d/99-maas
-# 
+#
 # Enable launchpad personal package archives for squid-deb-proxy
 ppa.launchpad.net
-# Enable access to MAAS server HTTP to allow squashfs download
-# during install
-maas.internal.example.com # maasurl

=== modified file 'debian/maas-cluster-controller.install'
--- debian/maas-cluster-controller.install	2012-11-06 16:41:05 +0000
+++ debian/maas-cluster-controller.install	2012-11-13 12:13:28 +0000
@@ -18,8 +18,6 @@
 etc/cron.d/maas-import-pxe-files
 man/maas-import-pxe-files.8 usr/share/man/man8
 debian/tmp/etc/maas/import_pxe_files
-debian/tmp/usr/sbin/maas-import-squashfs
-debian/tmp/etc/maas/import_squashfs
 debian/tmp/usr/sbin/maas-import-ephemerals
 debian/tmp/etc/maas/import_ephemerals
 debian/tmp/etc/maas/commissioning-user-data