launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #14215
[Merge] lp:~rharding/launchpad/security_banner_107842 into lp:launchpad
The proposal to merge lp:~rharding/launchpad/security_banner_107842 into lp:launchpad has been updated.
Description changed to:
Small fix to make sure we don't count public security as worthy of having the privacy banner showing with the warning.
To fix this we just update the event filters that signify what's private vs public. Adds tests for the information type values.
== QA ==
Just flip a bug from private security to public security and the banner should show/disappear.
For more details, see:
https://code.launchpad.net/~rharding/launchpad/security_banner_107842/+merge/134187
--
https://code.launchpad.net/~rharding/launchpad/security_banner_107842/+merge/134187
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
References