launchpad-reviewers team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

Review: Approve code

Looks good.

But I am wondering if we need to change the expression returned by ProductSet.getProductPrivacyFilter():

Users may have an artifact grant for a bug/branch/blueprint of a private product but not a policy grant for the product itself; I suspect that we should add a clause like APGF.artifact == None to address this case.

But this affects of course other callsites of getProductPrivacyFilter(), so we should probably talk about it in our standup call on Monday.
-- 
https://code.launchpad.net/~jcsackett/launchpad/filter-milestone-vocabulary-for-projectgroups/+merge/134667
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.