launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/bugzilla-greater-than-36 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1021390 in Launchpad itself: "remote bugzilla status update fails on bug"
  https://bugs.launchpad.net/launchpad/+bug/1021390

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/bugzilla-greater-than-36/+merge/134825

If we're chatting to a Bugzilla instance that is version 3.6.2 or higher, send "bugidtype=include", else send "bug_id_type=include". In my testing, this allows us to pull bugs from bugzilla.libav.org, and still able to pull from Abisource's bugzilla.
-- 
https://code.launchpad.net/~stevenk/launchpad/bugzilla-greater-than-36/+merge/134825
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/bugzilla-greater-than-36 into lp:launchpad.

=== modified file 'lib/lp/bugs/externalbugtracker/bugzilla.py'
--- lib/lp/bugs/externalbugtracker/bugzilla.py	2012-07-02 15:40:45 +0000
+++ lib/lp/bugs/externalbugtracker/bugzilla.py	2012-11-19 00:18:21 +0000
@@ -381,16 +381,19 @@
             buglist_page = 'buglist.cgi'
             data = {
                 'form_name': 'buglist.cgi',
-                'bug_id_type': 'include',
                 'columnlist':
                     ('id,product,bug_status,resolution,'
                      'priority,bug_severity'),
                 'bug_id': ','.join(bug_ids),
                 }
             if self.version < (2, 17, 1):
-                data.update({'format': 'rdf'})
-            else:
-                data.update({'ctype': 'rdf'})
+                data['format'] = 'rdf'
+            else:
+                data['ctype'] = 'rdf'
+            if self.version > (3, 6, 1):
+                data['bugidtype'] = 'include'
+            else:
+                data['bug_id_type'] = 'include'
             bug_tag = 'bz:bug'
             id_tag = 'bz:id'
             status_tag = 'bz:bug_status'