launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Badin has proposed merging lp:~rvb/maas/packaging.proxy-bug-1081229 into lp:~maas-maintainers/maas/packaging.

Commit message:
Update the sudo rule to allow preserving the environment when calling maas-import-pxe-files via sudo. We need this to preserve variables like 'http{,s}_proxy'.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~rvb/maas/packaging.proxy-bug-1081229/+merge/135361


-- 
https://code.launchpad.net/~rvb/maas/packaging.proxy-bug-1081229/+merge/135361
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/packaging.proxy-bug-1081229 into lp:~maas-maintainers/maas/packaging.

=== modified file 'debian/changelog'
--- debian/changelog	2012-11-13 20:40:07 +0000
+++ debian/changelog	2012-11-21 10:27:35 +0000
@@ -1,6 +1,9 @@
 maas (0.1+bzr1269+dfsg-0ubuntu2) UNRELEASED; urgency=low
 
   [ Raphaël Badin ]
+  * debian/extras/99-maas-sudoers: Add 'SETENV:' to sudo rule
+    to allow preserving the environment when running
+    /usr/sbin/maas-import-pxe-files via sudo.
   * debian/maas-dns.postinst: fix permissions and group ownership of
     file /etc/bind/maas/named.conf.rndc.maas. (LP: #1066935)
   * debian/control: Remove the dependency of maas-cluster-controller

=== modified file 'debian/extras/99-maas-sudoers'
--- debian/extras/99-maas-sudoers	2012-11-05 11:52:52 +0000
+++ debian/extras/99-maas-sudoers	2012-11-21 10:27:35 +0000
@@ -1,3 +1,3 @@
 maas ALL= NOPASSWD: /usr/sbin/service maas-dhcp-server restart
 maas ALL= NOPASSWD: /usr/sbin/maas-provision
-maas ALL= NOPASSWD: /usr/sbin/maas-import-pxe-files
+maas ALL= NOPASSWD: SETENV: /usr/sbin/maas-import-pxe-files