← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wgrant/launchpad/batch-publishinghistory into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Curtis Hovey <curtis.hovey@xxxxxxxxxxxxx>
Date: Wed, 21 Nov 2012 13:00:35 -0000
In-reply-to: <20121121083320.6147.58610.launchpad@ackee.canonical.com>
Reply-to: mp+135330@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

This looks good to land.

The addition of removeSecurityProxy to decoratedResultSet is interesting. Why wasn't this an issue in the past, or is was this the root cause of an oops/bug?
-- 
https://code.launchpad.net/~wgrant/launchpad/batch-publishinghistory/+merge/135330
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

[Merge] lp:~wgrant/launchpad/batch-publishinghistory into lp:launchpad
From: William Grant, 2012-11-21