← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~jcsackett/launchpad/filter-in-getRequestTargets into lp:launchpad

 

Review: Approve

In getRequestTargets and list_product_request_targets, having the user default to None means that calling code can accidentally omit it.  I think it should be a non-optional parameter, even though this means changing parameter order.

Other than that, this looks good to land.
-- 
https://code.launchpad.net/~jcsackett/launchpad/filter-in-getRequestTargets/+merge/135457
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References