launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

The proposal to merge lp:~rharding/launchpad/translatables into lp:launchpad has been updated.

Description changed to:

= Summary =

The .translations property and then getTranslatable methods it calls do not
take the privacy filter into account when querying.

== Pre Implementation ==

Talked with Deryck. getTranslatable is a method on both product and
projectgroup. In order to keep the api consistant we use the launchbag here as
was done in the product version of the method.

== Implementation Notes ==

Simple case of get the user and add the privacy filter to the query.

has_translatables() is based off the count of .translatables so this fixes
both points noted in the card.

== Tests ==

lib/lp/registry/model/projectgroup.py


For more details, see:
https://code.launchpad.net/~rharding/launchpad/translatables/+merge/135492
-- 
https://code.launchpad.net/~rharding/launchpad/translatables/+merge/135492
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/translatables into lp:launchpad.