launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/blueprints-in-ui-not-specification into lp:launchpad.

Commit message:
Updates Specification sharing policy to Blueprint sharing policy in the UI.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1052544 in Launchpad itself: ""Specifications" used where "blueprints" is meant"
  https://bugs.launchpad.net/launchpad/+bug/1052544

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/blueprints-in-ui-not-specification/+merge/135503

Summary
=======
On the sharing page, we refer to the Specification sharing policy; while in
some places we do reference specifications we generally want Blueprints.
Accordingly, this should be changed in the UI.

Preimp
======
None.

Implementation
==============
Updated UI facing uses of "Specification sharing policy" to "Blueprint sharing
policy".

Updated the title attribute of the pillar and product additionally; it's
possible these should be left alone. If the reviewer feels so, I'll change
them back without argument.

Updated reference in tests.

Tests
=====
bin/test -vvct test_pillarsharing

QA
==
Ensure the text is changed on the +sharing page.

LoC
===
Part of Private Projects.

Lint
====

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/interfaces/pillar.py
  lib/lp/registry/templates/pillar-sharing.pt
  lib/lp/registry/interfaces/product.py
  lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html
-- 
https://code.launchpad.net/~jcsackett/launchpad/blueprints-in-ui-not-specification/+merge/135503
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/blueprints-in-ui-not-specification into lp:launchpad.

=== modified file 'lib/lp/registry/interfaces/pillar.py'
--- lib/lp/registry/interfaces/pillar.py	2012-09-13 21:58:12 +0000
+++ lib/lp/registry/interfaces/pillar.py	2012-11-21 19:45:27 +0000
@@ -102,7 +102,7 @@
         required=False, readonly=True, vocabulary=BugSharingPolicy),
         as_of='devel')
     specification_sharing_policy = exported(Choice(
-        title=_('Specification sharing policy'),
+        title=_('Blueprint sharing policy'),
         description=_("Sharing policy for this project's specifications."),
         required=False, readonly=True, vocabulary=SpecificationSharingPolicy),
         as_of='devel')

=== modified file 'lib/lp/registry/interfaces/product.py'
--- lib/lp/registry/interfaces/product.py	2012-11-13 17:03:49 +0000
+++ lib/lp/registry/interfaces/product.py	2012-11-21 19:45:27 +0000
@@ -655,7 +655,7 @@
         required=True, readonly=True, vocabulary=BugSharingPolicy),
         as_of='devel')
     specification_sharing_policy = exported(Choice(
-        title=_('Specification sharing policy'),
+        title=_('Blueprint sharing policy'),
         description=_("Sharing policy for this project's specifications."),
         required=True, readonly=True, vocabulary=SpecificationSharingPolicy),
         as_of='devel')

=== modified file 'lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html'
--- lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html	2012-10-26 09:54:28 +0000
+++ lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html	2012-11-21 19:45:27 +0000
@@ -104,7 +104,7 @@
             </tr>
             <tr id="specification-sharing-policy-row">
                <td id="specification-sharing-policy">
-                 Specification sharing policy:&nbsp;
+                 Blueprint sharing policy:&nbsp;
                  <strong><span class="value"></span></strong>
                  <a class="editicon sprite edit action-icon"
                      style="padding-bottom: 0;">Edit</a>

=== modified file 'lib/lp/registry/templates/pillar-sharing.pt'
--- lib/lp/registry/templates/pillar-sharing.pt	2012-09-13 19:56:13 +0000
+++ lib/lp/registry/templates/pillar-sharing.pt	2012-11-21 19:45:27 +0000
@@ -79,7 +79,7 @@
         <tr id="specification-sharing-policy-row"
            tal:condition="view/specification_sharing_policies">
            <td id="specification-sharing-policy">
-             Specification sharing policy:&nbsp;
+             Blueprint sharing policy:&nbsp;
              <strong><span class="value"
                  tal:content="context/specification_sharing_policy/title|string:Legacy policy"
                  ></span></strong>