launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/roundup-keyerror into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/roundup-keyerror/+merge/135581

We are seeing an awful lot of OOPSes from the roundup externalbugtracker with a KeyError of id. Skip remote bugs that do not have one.
-- 
https://code.launchpad.net/~stevenk/launchpad/roundup-keyerror/+merge/135581
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/roundup-keyerror into lp:launchpad.

=== modified file 'lib/lp/bugs/externalbugtracker/roundup.py'
--- lib/lp/bugs/externalbugtracker/roundup.py	2011-01-23 09:34:35 +0000
+++ lib/lp/bugs/externalbugtracker/roundup.py	2012-11-22 03:24:22 +0000
@@ -233,6 +233,8 @@
         remote_bugs = csv.DictReader(self._fetchPage(query_url))
         bugs = {}
         for remote_bug in remote_bugs:
+            if 'id' not in remote_bug:
+                continue
             # We're only interested in the bug if it's one of the ones in
             # bug_ids.
             if remote_bug['id'] not in bug_ids: