launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code

Have you considered using the transaction decorators in lp.services.database? read_transaction, write_transaction, and retry_transaction can all be quite handy for replacing manual transaction management.


65	+ for product_name, series_name, glob in found_globs:
66	+ if last_product and last_product != product_name:

The rows won't necessarily be returned in product order, so this check doesn't make much sense.

114	+ def hasReleaseFile(self, filename, file_names):

The new version of this method is the dictionary definition of "not worth it". I'd inline it.

101	+ found_names = IStore(Product).find(
102	+ (LibraryFileAlias.filename),

Those parens are redundant.

110	+ file_names = set(name for name in found_names)

That's just "file_names = set(found_names)"
-- 
https://code.launchpad.net/~sinzui/launchpad/fast-prf/+merge/135451
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.