← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~julian-edwards/maas/cluster-wrong-address-bug-1081688 into lp:maas

 

Seems a bit of a hack to do it like this.  We may have to resort to that solution but Gavin and I talked briefly about that bug yesterday and we thought of a possible solution worth investigating: instead of sending the raw value of settings.DEFAULT_MAAS_URL on the server side, we could use the same trick that is used in src/maasserver/api.py:describe (at the very bottom of the file) and replace the host part of settings.DEFAULT_MAAS_URL with the host extracted from the request (see build_absolute_uri in src/maasserver/utils/__init__.py).  This way, the host part of the url returned would be the ip from which the original request came from.
-- 
https://code.launchpad.net/~julian-edwards/maas/cluster-wrong-address-bug-1081688/+merge/135596
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/maas/cluster-wrong-address-bug-1081688 into lp:maas.


Follow ups

References