launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

> Translations must not exist at all, not just be disabled. Answers must also
> not exist.

I know this, and I've already started work on addressing that.  See bug #1082422 and branch  lp:~abentley/launchpad/more-transition-checks.  Please add any checks that I've missed to that bug.

> There's also some arbitrary capitalisation here:
> 
> 274     + raise CommercialSubscribersOnly(
> 275     + 'A valid commercial subscription is required for private'
> 276     + ' Projects.')

True, but I only moved that code around.
-- 
https://code.launchpad.net/~abentley/launchpad/transitive-confidential/+merge/135926
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.