launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/blueprints-in-ui-not-specification-2 into lp:launchpad.

Commit message:
Change mentions of "specification" to "blueprint" in the descriptions in SpecificationSharingPolicy, since they show in the UI.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1052544 in Launchpad itself: ""Specifications" used where "blueprints" is meant"
  https://bugs.launchpad.net/launchpad/+bug/1052544

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/blueprints-in-ui-not-specification-2/+merge/136213

Summary
=======
We updated the UI on +sharing to say "Blueprint sharing policy" rather than
"Specification sharing policy", but the enum descriptions for the policy
still reference specifications. Since these descriptions are shown in the UI
along with the "Blueprint sharing policy" label, the descriptions should be
updated as well.

Preimp
======
None.

Implementation
==============
Changed all mentions of "specification" to "blueprint" in the sharing policy
enum.

QA
==
Ensure the display is correct in +sharing.

LoC
===
Part of private projects.

Lint
====

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/enums.py
-- 
https://code.launchpad.net/~jcsackett/launchpad/blueprints-in-ui-not-specification-2/+merge/136213
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/blueprints-in-ui-not-specification-2 into lp:launchpad.

=== modified file 'lib/lp/registry/enums.py'
--- lib/lp/registry/enums.py	2012-11-16 20:55:48 +0000
+++ lib/lp/registry/enums.py	2012-11-26 16:14:21 +0000
@@ -144,42 +144,42 @@
     PUBLIC = DBItem(1, """
         Public
 
-        Specifications are public.
+        Blueprints are public.
         """)
 
     PUBLIC_OR_PROPRIETARY = DBItem(2, """
         Public, can be proprietary
 
-        New specifications are public, but can be made proprietary later.
+        New blueprints are public, but can be made proprietary later.
         """)
 
     PROPRIETARY_OR_PUBLIC = DBItem(3, """
         Proprietary, can be public
 
-        New specifications are proprietary, but can be made public later. Only
+        New blueprints are proprietary, but can be made public later. Only
         people who can see the project's proprietary information can create
-        new specifications.
+        new blueprints.
         """)
 
     PROPRIETARY = DBItem(4, """
         Proprietary
 
-        Specifications are always proprietary. Only people who can see the
-        project's proprietary information can create new specifications.
+        Blueprints are always proprietary. Only people who can see the
+        project's proprietary information can create new blueprints.
         """)
 
     EMBARGOED_OR_PROPRIETARY = DBItem(5, """
         Embargoed, can be proprietary
 
-        New specifications are embargoed, but can be made proprietary later.
+        New blueprints are embargoed, but can be made proprietary later.
         Only people who can see the project's proprietary information can
-        create new specifications.
+        create new blueprints.
         """)
 
     FORBIDDEN = DBItem(6, """
         Forbidden
 
-        No new specifications may be created, but existing specifications may
+        No new blueprints may be created, but existing blueprints may
         still be updated.
         """)