← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~sinzui/launchpad/redirect-201 into lp:launchpad

 

Review: Approve code

The branch looks good.

Trivial thought: it might be nice if the list of status codes that do not trigger a page render were stored in a variable so the tests could iterate over them instead of having to keep the tests in sync with the implementation.
-- 
https://code.launchpad.net/~sinzui/launchpad/redirect-201/+merge/136198
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References