launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve

Thanks, love the generator solution.

#31

How do the errors look when joined? Since we're just joining with a space I wonder if we need to find a way to get into the rendering and force a break/new line between errors for display? 

#196

Party personal question part suggestion. What is an inclusive membership? Since these errors are going to get presented to the user they're going to go looking for a way to fix them and I worry that this error won't be clear enough to direct users to find/remove the condition.


-- 
https://code.launchpad.net/~abentley/launchpad/more-transition-checks/+merge/136284
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.