launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/commissioning-tarball into lp:maas has been updated.

Description changed to:

This was discussed with several people.  What you see here is just the model part: "give me a tar archive containing all commissioning scripts."  In all likelihood this will be a very small and simple tar file, but if it turns out to be large or expensive to produce, we can then worry about caching it (and where) and maybe compressing it (and where).  We should be able to manage those pretty transparently; there are no design warts to accommodate optimization.

The next step will be to provide this tarball on the metadata API.  If we ever want to specialize the tarballs for different kinds of nodes, the model method can sprout filtering parameters but the API won't change — the requesting node's identity is already an implicit part of every metadata request.

You may wonder about the path prefix I used for files in the archive.  That's because commissioning scripts might not be all we'll ever want to put in there.  For example, if you had a commissioning script in python, you might also want to send along supporting modules.  Those modules would have to go in a predictable location, they should not be executed directly, and the convenient thing would be to send them along as part of the same tarball.  Not saying we'd be doing something like that soon, just that this keeps our options open.


Jeroen

For more details, see:
https://code.launchpad.net/~jtv/maas/commissioning-tarball/+merge/137045
-- 
https://code.launchpad.net/~jtv/maas/commissioning-tarball/+merge/137045
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/commissioning-tarball into lp:maas.