← Back to team overview

launchpad-reviewers team mailing list archive

  1. launchpad-reviewers team
  2. Mailing list archive
  3. Message #14697

Re: [Merge] lp:~sinzui/launchpad/revision-karma-1 into lp:launchpad

  Thread Previous • Date Previous • • Thread Next 
Review: Approve code

The branch looks good, especially the code consolodation.

Changing the "fail.." calls to "assert..." calls was a nice touch.

-- 
https://code.launchpad.net/~sinzui/launchpad/revision-karma-1/+merge/137660
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

  Thread Previous • Date Previous • • Thread Next