launchpad-reviewers team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

Abel Deuring has proposed merging lp:~adeuring/launchpad/bug-1086057 into lp:launchpad.

Commit message:
change permissions for IProductSeries so that users with an artifact grant for a bug for a private product and linked to a milestone or product series can view these bugs.

Requested reviews:
  Richard Harding (rharding)
Related bugs:
  Bug #1086057 in Launchpad itself: "Users with an artifact grant for a bug related to a private product can't view the bug page."
  https://bugs.launchpad.net/launchpad/+bug/1086057

For more details, see:
https://code.launchpad.net/~adeuring/launchpad/bug-1086057/+merge/138086

fix for bug 1086057: Users with an artifact grant for a bug related to
a private product can't view the bug page

I filed this bug together with bug 1086043. The changes from the branch
that fixed 1086043 already allowed to view bugs of proprietary products,
when these bugs had only a bugtask for the product itself or when a
milestone is linked to the bugtask. Bugs with a task for a series of
the proprietary product needed some additional changes: Several
ProductSeries attributes need the permission lp.LimitedView instead
of lp.View.

These attributes are defined in IStructuralSubscriptionTarget and in
IBugTarget. registry/configure.zcml now specifies the permission
for each attribute of these interfaces individually, not for the
entire interfaces, similar to the permission definitions for these
attributes in IProduct.

Tests:

./bin/test bugs -vvt test_bug_views.TestMainBugView
./bin/test registry -vvt lp.registry.tests.test_productseries.ProductSeriesSecurityAdaperTestCase

no lint

-- 
https://code.launchpad.net/~adeuring/launchpad/bug-1086057/+merge/138086
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.