launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/pkg-bug-1086239 into lp:~maas-maintainers/maas/packaging has been updated.

Description changed to:

As per discussion with Julian.  The tftpd needs to know the UUID for the cluster it serves, in order to pass it to the pxeconfig API call.  Currently that UUID is only configured in the celery config, and we don't want to import that into the pserv process (which is what serves our tftp).  We intend to clean up the duplication later, leaving only the new location for the UUID setting, where both our celery processes and our pserv processes can read it.

Once this branch is landed, we can have pserv read the UUID from maas_cluster.conf instead of from maas_local_celeryconfig_cluster.py.  To prepare for this, I made the upstart script for pserv read the cluster config just like the one for the main cluster process does.

The main cost factor for this branch was our inability to unit-test the packaging scripts.  I verified manually that the new code does the right thing both during upgrade and in a fresh install.

Jeroen

For more details, see:
https://code.launchpad.net/~jtv/maas/pkg-bug-1086239/+merge/139146
-- 
https://code.launchpad.net/~jtv/maas/pkg-bug-1086239/+merge/139146
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/pkg-bug-1086239 into lp:~maas-maintainers/maas/packaging.