launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/pkg-bug-1089819 into lp:~maas-maintainers/maas/packaging.

Commit message:
Export CLUSTER_UUID from the cluster controller's upstart jobs to their respective daemon child processes.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1089819 in MAAS: "CLUSTER_UUID not exported to pserv & cluster-controller processes"
  https://bugs.launchpad.net/maas/+bug/1089819

For more details, see:
https://code.launchpad.net/~jtv/maas/pkg-bug-1089819/+merge/139647

The upstart jobs for pserv (the tftpd) and celery (start-cluster-controller) now source maas_cluster.conf, but they also need to export CLUSTER_UUID to get it included in the environments of the respective child processes they fork off.

Raphaël and I discussed the option of sticking the uuid on the command line as an option, but decided we didn't want to expose it to untrusted users on the same system.


Jeroen
-- 
https://code.launchpad.net/~jtv/maas/pkg-bug-1089819/+merge/139647
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/pkg-bug-1089819 into lp:~maas-maintainers/maas/packaging.

=== modified file 'debian/maas-cluster-controller.maas-cluster-celery.upstart'
--- debian/maas-cluster-controller.maas-cluster-celery.upstart	2012-10-03 03:43:27 +0000
+++ debian/maas-cluster-controller.maas-cluster-celery.upstart	2012-12-13 10:10:45 +0000
@@ -21,6 +21,10 @@
 end script
 
 script
-    . $CONFIG_FILE  # sets MAAS_URL
+    # Prepare settings.
+    . $CONFIG_FILE
+    # Allow the cluster-controller process to read CLUSTER_UUID as set
+    # in that config file.
+    export CLUSTER_UUID
     exec /usr/sbin/maas-provision start-cluster-controller $MAAS_URL -u maas -g maas
 end script

=== modified file 'debian/maas-cluster-controller.maas-pserv.upstart'
--- debian/maas-cluster-controller.maas-pserv.upstart	2012-12-11 09:03:17 +0000
+++ debian/maas-cluster-controller.maas-pserv.upstart	2012-12-13 10:10:45 +0000
@@ -23,6 +23,9 @@
 script
     # Prepare settings.
     . $CONFIG_FILE
+    # Allow the tftpd process to read CLUSTER_UUID as set in that config
+    # file.
+    export CLUSTER_UUID
     # To add options to your daemon, edit the line below:
     exec /usr/bin/twistd -n --uid=maas --gid=maas --pidfile=/run/maas-pserv.pid --logfile=/dev/null maas-pserv --config-file=/etc/maas/pserv.yaml
 end script